SageTV Community  

Go Back   SageTV Community > SageTV Development and Customizations > SageTV Github Development

Notices

SageTV Github Development Discussion related to SageTV Open Source Development. Use this forum for development topics about the Open Source versions of SageTV, hosted on Github.

Reply
 
Thread Tools Search this Thread Display Modes
  #21  
Old 08-12-2015, 10:05 AM
HelenWeathers's Avatar
HelenWeathers HelenWeathers is offline
Sage Icon
 
Join Date: Aug 2008
Location: Miami, Florida
Posts: 1,321
narflex, stanger89, wayner etc have it right IMO.

Core should contain:

TV recording functionality
Video, live TV and music playback with photo viewing
EPG support

I also use the "TV Show Editorials" feature weekly (moreso in September) to see if there's anything new coming down the pike. The name could change to "Upcoming TV" or something a little more descriptive to what it provides for the average user. (I've renamed mine in the menu already)

I don't use "Intelligent Recording" myself but know other users who do.

I just want to see the core remain the best there is and as bug free as possible.

There could be better descriptions of what plugins do, but I personally would like to keep the vast majority of plugins as just that - PlugIns
__________________
Server: SageTV 9, Win10/32, Intel DP55KG Mb, Intel QC i5 2.66GHz , 4GB 1333MHz DDR3 SDRAM, 2 Hauppauge 2255s for 4 OTA ATSC tuners, HDHRPrime w Comcast, 3 STP-HD300s 20101007-0 firmware, nVidia Shield. Java v7u55. Plugins:SD EPG, OpenDCT
Reply With Quote
  #22  
Old 08-12-2015, 10:22 AM
Tiki's Avatar
Tiki Tiki is offline
Sage Icon
 
Join Date: Feb 2005
Location: Southwest Florida, USA
Posts: 1,992
Quote:
Originally Posted by HelenWeathers View Post
narflex, stanger89, wayner etc have it right IMO.

Core should contain:

TV recording functionality
Video, live TV and music playback with photo viewing
EPG support

I also use the "TV Show Editorials" feature weekly (moreso in September) to see if there's anything new coming down the pike. The name could change to "Upcoming TV" or something a little more descriptive to what it provides for the average user. (I've renamed mine in the menu already)

I don't use "Intelligent Recording" myself but know other users who do.

I just want to see the core remain the best there is and as bug free as possible.

There could be better descriptions of what plugins do, but I personally would like to keep the vast majority of plugins as just that - PlugIns
+1
__________________
Server: Ryzen 2400G with integrated graphics, ASRock X470 Taichi Motherboard, HDMI output to Vizio 1080p LCD, Win10-64Bit (Professional), 16GB RAM
Capture Devices (7 tuners): Colossus (x1), HDHR Prime (x2)
,USBUIRT (multi-zone)
Source:
Comcast/Xfinity X1 Cable
Primary Client: Server Other Clients: (1) HD200, (1) HD300
Retired Equipment: MediaMVP, PVR150 (x2), PVR150MCE,
HDHR, HVR-2250, HD-PVR
Reply With Quote
  #23  
Old 08-12-2015, 10:36 AM
stanger89's Avatar
stanger89 stanger89 is offline
SageTVaholic
 
Join Date: May 2003
Location: Marion, IA
Posts: 15,188
The thing to remember though, is there's two issues here, and they are not the same:

1) The SageTV architecture, what components/features should be "plugins" and what parts should be built in.
2) The "SageTV" package, what should be included and automatically installed/configured when you run the installer.

What most of the requests I'm reading are looking for is for features to be included as part of 2. Ie, when you run the SageTV installer you get (the option?) to install the web interface, comskip playback, etc.

However just because something is 2, included in the installer, doesn't mean it can't be a "plugin".

Quote:
Originally Posted by reggie14 View Post
There is some notion of core functionality, but despite the popularity of commercial skipping and the web interface I'm not convinced those really belong as core. I don't even think I'd want those plugins installed by default.
The biggest issue with adding functionality to the core (ie not added via the plugin system) is that any update to those features requires a rebuild and re-release of the core to get it out to the public.

Quote:
Out of curiosity, where does Schedules Direct support fall? EPG data is very much a core feature of a DVR, so on that basis it makes sense as part of the core. At the same time, it might be best to think of any EPG source as a plugin. If something changes with one of those sources you don't want to have to put out a whole new release.
I do like the idea of EPG sources being plugins, but I think it would be good to bundle Schedules Direct to it's installed by default.
Reply With Quote
  #24  
Old 08-12-2015, 10:51 AM
Fuzzy's Avatar
Fuzzy Fuzzy is offline
SageTVaholic
 
Join Date: Sep 2005
Location: Jurupa Valley, CA
Posts: 9,957
Quote:
Originally Posted by HelenWeathers View Post
narflex, stanger89, wayner etc have it right IMO.

Core should contain:

TV recording functionality
Video, live TV and music playback with photo viewing
EPG support

I also use the "TV Show Editorials" feature weekly (moreso in September) to see if there's anything new coming down the pike. The name could change to "Upcoming TV" or something a little more descriptive to what it provides for the average user. (I've renamed mine in the menu already)

I don't use "Intelligent Recording" myself but know other users who do.

I just want to see the core remain the best there is and as bug free as possible.

There could be better descriptions of what plugins do, but I personally would like to keep the vast majority of plugins as just that - PlugIns
Also realize that a LARGE part of the core has nothing to do with recording OR playing back media. I'd say a bulk of the code is system management and UI.
Quote:
Originally Posted by stanger89 View Post
I do like the idea of EPG sources being plugins, but I think it would be good to bundle Schedules Direct to it's installed by default.
by that token, it would also make sense to work towards moving some things (like the Google/Sage EPG Source) out of the core and INTO a plugin.
__________________
Buy Fuzzy a beer! (Fuzzy likes beer)

unRAID Server: i7-6700, 32GB RAM, Dual 128GB SSD cache and 13TB pool, with SageTVv9, openDCT, Logitech Media Server and Plex Media Server each in Dockers.
Sources: HRHR Prime with Charter CableCard. HDHR-US for OTA.
Primary Client: HD-300 through XBoxOne in Living Room, Samsung HLT-6189S
Other Clients: Mi Box in Master Bedroom, HD-200 in kids room
Reply With Quote
  #25  
Old 08-12-2015, 10:58 AM
stanger89's Avatar
stanger89 stanger89 is offline
SageTVaholic
 
Join Date: May 2003
Location: Marion, IA
Posts: 15,188
Quote:
Originally Posted by Fuzzy View Post
by that token, it would also make sense to work towards moving some things (like the Google/Sage EPG Source) out of the core and INTO a plugin.
True, though that's likely a big waste of development resources.
Reply With Quote
  #26  
Old 08-12-2015, 11:04 AM
rkulagow's Avatar
rkulagow rkulagow is offline
Sage Advanced User
 
Join Date: Feb 2013
Posts: 156
If there is going to be effort made to include Schedules Direct as a native option, then it may be fruitful to look at what sort of data we have available. I believe that slugger's grabber tried to take advantage of as much as was possible, but I don't know if everything that we have available had someplace that fit within the existing EPG schema in Sage, so there was a lot of "translating" that needed to be done.
Reply With Quote
  #27  
Old 08-12-2015, 12:00 PM
Narflex's Avatar
Narflex Narflex is offline
Sage
 
Join Date: Feb 2003
Location: Redondo Beach, CA
Posts: 6,319
Couple of comments relating to all this

1. Comskip isn't something that should be included by default because it's not fully cross platform....running it on Linux requires using Wine which isn't an option for all setups (such as mine...I'm the only person who's actually running the 'sagetv on a stick' setup that we talked about many years ago). If this has changed...and there's a native Linux commercial skipping setup...PLEASE correct me on that.

2. I think the SD EPG plugin should be another option in the SageTV core. EPG data is so critical to proper functioning. My suggestion would be to essentially use the WarlockRipper (legacy EPG client code) if there is a SageTV license key present...and use SD if there is not. I'm assuming other SD config is needed (such as a license key); so that should be prompted for in the UI or something like that to facilitate easy setup of the EPG system for a new user.
__________________
Jeffrey Kardatzke
Google
Founder of SageTV
Reply With Quote
  #28  
Old 08-12-2015, 12:09 PM
dinki's Avatar
dinki dinki is offline
Sage Expert
 
Join Date: Mar 2006
Posts: 682
Quote:
Originally Posted by Narflex View Post
...I'm the only person who's actually running the 'sagetv on a stick' setup that we talked about many years ago
Not to derail, but can you tell us more about the 'sagetv on a stick'? Is it a true bootable SageTV appliance (OS with SageTV installed) or is it something entirely different?
__________________
Intel Core i5-2500, 16GB RAM, OMV Linux 4.17, 3 TB of Data
SageTV 9 Docker, Open DCT Docker
Silicondust HDHomeRun Duo + Quatro
Sage Mini Client on Amazon Fire Sticks and Android TVs
Reply With Quote
  #29  
Old 08-12-2015, 12:17 PM
Fuzzy's Avatar
Fuzzy Fuzzy is offline
SageTVaholic
 
Join Date: Sep 2005
Location: Jurupa Valley, CA
Posts: 9,957
Quote:
Originally Posted by stanger89 View Post
True, though that's likely a big waste of development resources.
I'm not sure it would take all that much. The data source is already in it's own class, it's just that class is currently rolled into the sage.jar file. It could be moved into it's own package, and the specific calls to it abstracted out so it is treated like any other future data source plugin. It will make maintainability so much better if all data sources are treated the same in the code, especially since the number of sage epg users will only ever decrease.
__________________
Buy Fuzzy a beer! (Fuzzy likes beer)

unRAID Server: i7-6700, 32GB RAM, Dual 128GB SSD cache and 13TB pool, with SageTVv9, openDCT, Logitech Media Server and Plex Media Server each in Dockers.
Sources: HRHR Prime with Charter CableCard. HDHR-US for OTA.
Primary Client: HD-300 through XBoxOne in Living Room, Samsung HLT-6189S
Other Clients: Mi Box in Master Bedroom, HD-200 in kids room
Reply With Quote
  #30  
Old 08-12-2015, 12:18 PM
Narflex's Avatar
Narflex Narflex is offline
Sage
 
Join Date: Feb 2003
Location: Redondo Beach, CA
Posts: 6,319
Quote:
Originally Posted by dinki View Post
Not to derail, but can you tell us more about the 'sagetv on a stick'? Is it a true bootable SageTV appliance (OS with SageTV installed) or is it something entirely different?
It's a read-only USB stick with a headless Ubuntu OS on it and SageTV software (plus many other bits like Samba). Then I have a RAID 5 setup that mounts into it and provides all of the writable medium. You may notice stuff in the sage.FSManager java class about monitoring RAID arrays...so I get system messages in SageTV if there's issues with my RAID setup.
__________________
Jeffrey Kardatzke
Google
Founder of SageTV
Reply With Quote
  #31  
Old 08-12-2015, 12:21 PM
Fuzzy's Avatar
Fuzzy Fuzzy is offline
SageTVaholic
 
Join Date: Sep 2005
Location: Jurupa Valley, CA
Posts: 9,957
Quote:
Originally Posted by Narflex View Post
Comskip isn't something that should be included by default because it's not fully cross platform....running it on Linux requires using Wine which isn't an option for all setups (such as mine...I'm the only person who's actually running the 'sagetv on a stick' setup that we talked about many years ago). If this has changed...and there's a native Linux commercial skipping setup...PLEASE correct me on that.
I would agree that comskip processing shouldn't necessarily be built into the core, but .EDL reading probably should be brought in to the main STV. In addition to this, I think it would be wise if .EDL files would be parsed and put into a metadata field, so the .EDL file doesn't have to be equally accessible to all clients, and would instead simply be a part of the mediafile object itself.
__________________
Buy Fuzzy a beer! (Fuzzy likes beer)

unRAID Server: i7-6700, 32GB RAM, Dual 128GB SSD cache and 13TB pool, with SageTVv9, openDCT, Logitech Media Server and Plex Media Server each in Dockers.
Sources: HRHR Prime with Charter CableCard. HDHR-US for OTA.
Primary Client: HD-300 through XBoxOne in Living Room, Samsung HLT-6189S
Other Clients: Mi Box in Master Bedroom, HD-200 in kids room
Reply With Quote
  #32  
Old 08-12-2015, 12:22 PM
BobPhoenix BobPhoenix is offline
SageTVaholic
 
Join Date: Oct 2004
Posts: 3,152
Quote:
Originally Posted by Fuzzy View Post
I would agree that comskip processing shouldn't necessarily be built into the core, but .EDL reading probably should be brought in to the main STV. In addition to this, I think it would be wise if .EDL files would be parsed and put into a metadata field, so the .EDL file doesn't have to be equally accessible to all clients, and would instead simply be a part of the mediafile object itself.
I like this idea.
__________________
"Keep your goals away from the trolls"
Reply With Quote
  #33  
Old 08-12-2015, 02:05 PM
rkulagow's Avatar
rkulagow rkulagow is offline
Sage Advanced User
 
Join Date: Feb 2013
Posts: 156
Quote:
Originally Posted by rkulagow View Post
... but I don't know if everything that we have available had someplace that fit within the existing EPG schema in Sage, so there was a lot of "translating" that needed to be done.
One example of this that I've run into the is the concept of channel numbers as integers vs. strings. Some providers will put alternate content on a "minor" channel; DirecTV did this a lot with "channel 219" being "ESPN", but "219-1" was ESPN-alternate 1, "219-2" ESPN-alternate 2, etc. I believe that this was an issue with Sage, and with the stationIDs as well. (That things were integers and not strings internally?) slugger could expand on it if he's not on vacation, or people could look at the sourcecode, but non-integer channel numbers and stationIDs are something which you may want to accommodate, especially if Sage plans on being made available outside the U.S. and Canada.
Reply With Quote
  #34  
Old 08-12-2015, 03:15 PM
Narflex's Avatar
Narflex Narflex is offline
Sage
 
Join Date: Feb 2003
Location: Redondo Beach, CA
Posts: 6,319
Quote:
Originally Posted by rkulagow View Post
One example of this that I've run into the is the concept of channel numbers as integers vs. strings. Some providers will put alternate content on a "minor" channel; DirecTV did this a lot with "channel 219" being "ESPN", but "219-1" was ESPN-alternate 1, "219-2" ESPN-alternate 2, etc. I believe that this was an issue with Sage, and with the stationIDs as well. (That things were integers and not strings internally?) slugger could expand on it if he's not on vacation, or people could look at the sourcecode, but non-integer channel numbers and stationIDs are something which you may want to accommodate, especially if Sage plans on being made available outside the U.S. and Canada.
The change was made a long time ago to make channel numbers strings and not integers. StationIDs are integers because they are unique keys for channels.
__________________
Jeffrey Kardatzke
Google
Founder of SageTV
Reply With Quote
  #35  
Old 08-12-2015, 03:38 PM
ThePaladinTech's Avatar
ThePaladinTech ThePaladinTech is offline
Sage Aficionado
 
Join Date: Oct 2007
Location: South Lyon, MI
Posts: 452
Quote:
Originally Posted by HelenWeathers View Post
narflex, stanger89, wayner etc have it right IMO.

Core should contain:

TV recording functionality
Video, live TV and music playback with photo viewing
EPG support

I also use the "TV Show Editorials" feature weekly (moreso in September) to see if there's anything new coming down the pike. The name could change to "Upcoming TV" or something a little more descriptive to what it provides for the average user. (I've renamed mine in the menu already)

I don't use "Intelligent Recording" myself but know other users who do.

I just want to see the core remain the best there is and as bug free as possible.

There could be better descriptions of what plugins do, but I personally would like to keep the vast majority of plugins as just that - PlugIns
I Agree as well
__________________
(current) SageServer: SageTV Open Source V9 - Virtual Ubuntu on Win10 HyperV MSI 970A-G46, AMD FX-8370 , SD Prime via OpenDCT, Donater ComSkip
Clients: HD-200, Nexus Player w/ Android miniclient
Storage: "nas" 16 drive Win10 w/ DrivePool running Plex, Emby, & SD PVR
Retired - Hava, MediaMVP, HD-100, HD-PVR, HVR-2250, Ceton InfiniTV4, Original (white) HDHomeRun Died - HD-100, HD-300
Reply With Quote
  #36  
Old 08-12-2015, 06:13 PM
GKusnick's Avatar
GKusnick GKusnick is offline
SageTVaholic
 
Join Date: Dec 2005
Posts: 5,083
Put me in the camp of keeping plugins as plugins rather then migrating them into the core.

In addition to what Stanger said about release schedules, a plugin doesn't have to please everyone. There's room for an ecosystem of narrowly targeted plugins that cater to different needs. But as soon as you put something in the core, you're committed to one-size-fits-all, and the result is feature bloat, and a configuration screen with a thousand options that most people will never use.

That said, it seems to me that much of what's being wished for here can be done with plugins even in V7.

EDL files as metadata? Get/SetMediaFileMetadata.

One-click installation of the five most popular plugins? Make a dummy plugin representing the bundle, and add the plugins you want to bundle as dependencies.

Duplicate your existing plugin configuration? Same idea: write a plugin to walk the graph of installed plugins, identify the top-level plugins on which everything else depends, and make a bundle out of them.
__________________
-- Greg
Reply With Quote
  #37  
Old 08-12-2015, 06:21 PM
Rob Rob is offline
Sage Expert
 
Join Date: Sep 2003
Posts: 568
I like the plug ins as plug ins. The way they are installed is very simple to manage.

What I wish was in the core is support for the HD Prime (sageDCT works, but is not really a plug in) and support for subtitles in the sage client.
Reply With Quote
  #38  
Old 08-12-2015, 06:47 PM
Fuzzy's Avatar
Fuzzy Fuzzy is offline
SageTVaholic
 
Join Date: Sep 2005
Location: Jurupa Valley, CA
Posts: 9,957
Quote:
Originally Posted by Rob View Post
What I wish was in the core is support for the HD Prime (sageDCT works, but is not really a plug in) and support for subtitles in the sage client.
I think going forward, all tuner support will be via network encoders. A lot of the configuration issues with the current encoders could be fixed by utilizing some undocumented auto-detection and configuration features in the network encoder protocol that we now have a view of in the source. And, to make things 'cleaner', PrimeNetEncoder, and others, probably should be available to be installed via the plugin system.
__________________
Buy Fuzzy a beer! (Fuzzy likes beer)

unRAID Server: i7-6700, 32GB RAM, Dual 128GB SSD cache and 13TB pool, with SageTVv9, openDCT, Logitech Media Server and Plex Media Server each in Dockers.
Sources: HRHR Prime with Charter CableCard. HDHR-US for OTA.
Primary Client: HD-300 through XBoxOne in Living Room, Samsung HLT-6189S
Other Clients: Mi Box in Master Bedroom, HD-200 in kids room
Reply With Quote
  #39  
Old 08-12-2015, 07:16 PM
tmiranda's Avatar
tmiranda tmiranda is offline
SageTVaholic
 
Join Date: Jul 2005
Location: Central Florida, USA
Posts: 5,851
Quote:
Originally Posted by GKusnick View Post
Put me in the camp of keeping plugins as plugins rather then migrating them into the core.
Welcome back Greg
__________________

Sage Server: 8th gen Intel based system w/32GB RAM running Ubuntu Linux, HDHomeRun Prime with cable card for recording. Runs headless. Accessed via RD when necessary. Four HD-300 Extenders.
Reply With Quote
  #40  
Old 08-13-2015, 03:04 AM
Damstas Damstas is offline
Sage User
 
Join Date: Mar 2015
Location: Helsinki, Finland
Posts: 39
Could these features be added to the core:

In addition to Schedules Direct, TheTVDB and TMDB search. The engine would need to be programmed to bypass the Nordic EPG age restriction, which are at the end of the show name: (7), (12), (16), (18), (R), (S) and (T). This feature is already in NextPVR.
Movies have "Elokuva:" in front of them, atleast in Finland.

Card server and Phoenix card reader support or card support in general (!!!!)

Comskip support

JSON for Schedules Direct

Last edited by Damstas; 08-13-2015 at 03:19 AM.
Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
dual core or quad core AMD processors tvmaster2 Hardware Support 4 10-30-2014 11:44 PM
To get a faster dual-core or slower quad-core? That is the question... robogeek Hardware Support 33 03-09-2009 08:33 PM
ERROR (-10)... Only with Quad core, not Dual core? jerryt Hardware Support 2 04-03-2008 07:13 PM
quad core vs dual core garyellis Hardware Support 16 03-13-2008 10:36 PM


All times are GMT -6. The time now is 04:00 PM.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2022, vBulletin Solutions Inc.
Copyright 2003-2005 SageTV, LLC. All rights reserved.