P3 beta testing feedback

[stuckless]

Originally Posted by panteragstk

Ah. Well I'm using the android client and the simple remote that came with the shield. No home button.

Back button, if you hit it a couple times, should bring you home.

[jusjoken]

Originally Posted by stuckless

Back button, if you hit it a couple times, should bring you home.

I don't think that will help as back a few time to get to the main menu is not the same as hitting home when in the default STV to return to a custom STV.

Once on the main menu you can select Exit and there will be a new option to return to the custom STV

k

[stuckless]

Originally Posted by jusjoken

I don't think that will help as back a few time to get to the main menu is not the same as hitting home when in the default STV to return to a custom STV.

Once on the main menu you can select Exit and there will be a new option to return to the custom STV

k

Maybe you're right... i thought I just used the back button (because I did jump to detailed setup from phoenix a few times), but maybe I long pressed the select button to bring up the on screen nav buttons and then selected home.

[bialio]

I think you are both right. There's a new menu item, and the back key eventually gets you there.

btl.

[panteragstk]

Originally Posted by stuckless

Maybe you're right... i thought I just used the back button (because I did jump to detailed setup from phoenix a few times), but maybe I long pressed the select button to bring up the on screen nav buttons and then selected home.

Back button got me back to the main Phoenix menu.

[panteragstk]

My primary client is the shield with miniclient installed.

A few things I've noticed are:

Screensaver doesn't do anything. It just sits at the main menu, but only displays the background.

Commercials aren't automatically skipping (already said by someone else)

When I go to look at plugins the menu goes to what is installed. No way I can see what is available. Not sure this matters since Phoenix has everything built in.

Is there a way to make the Unwatched filter stick? I'm still learning the phoneix xml to edit my menus. Anything you could point me to would be great as far as what options to use. I looked at the main vfs file, but I'm not too sure what to look for.

Overall I really like what you've done. Very smooth and very fast.

[panteragstk]

Noticed a few more strange things. If I'm watching a recorded TV show and press back for some reason it will go to live TV. Not sure if that is by design or not.

Also, comskip quit scanning new recordings when I started using P3. Not sure why that would matter as it has been working with the unRAID docker well before I started using P3. Went back to my old .xml and it started working again.

Very odd.

[stuckless]

Originally Posted by panteragstk

Also, comskip quit scanning new recordings when I started using P3. Not sure why that would matter as it has been working with the unRAID docker well before I started using P3. Went back to my old .xml and it started working again.

Very odd.

So my post in the Comskip forum, might be a bug with Comskip and P3... since I have the behaviour, ie, no automatic comskip since moving to P3.

https://forums.sagetv.com/forums/sho...&postcount=984

[bialio]

Automatic comskip works in P3, there just isn't a way to enable it currently. I'll have a release this weekend that adds it.

P3 doesn't have any impact on the Commercial plugin that scans new recordings. It shouldn't at least. It scans them for me at least, and I've been on P3 for months.

[bialio]

Although now that I think about it, I did have a bit of time where commercials weren't detected. I manually scheduled them and they all ran. I haven't really looked since then... So maybe it is broken.

[stuckless]

Originally Posted by bialio

Automatic comskip works in P3, there just isn't a way to enable it currently. I'll have a release this weekend that adds it.

P3 doesn't have any impact on the Commercial plugin that scans new recordings. It shouldn't at least. It scans them for me at least, and I've been on P3 for months.

yeah, the automatic skip is not something that I'm looking for... but since going to P3, I'm not getting comskip to automatically start when a recording ends (I guess both of those are automatic )

My post in the Comskip area does say, that the P3 thing is likely a coincidence... It comskip would automatically start before install p3... but now it doesn't, and I have no idea of those things are related

[panteragstk]

Originally Posted by stuckless

yeah, the automatic skip is not something that I'm looking for... but since going to P3, I'm not getting comskip to automatically start when a recording ends (I guess both of those are automatic )

My post in the Comskip area does say, that the P3 thing is likely a coincidence... It comskip would automatically start before install p3... but now it doesn't, and I have no idea of those things are related

That is odd considering they don't have anything to do with one another.

What can I look for to try and help figure this out?

[bialio]

I'll check when I get home today to see if P3 is for some reason consuming the RecordingCompleted hook. I would be surprised if it was, and even if P3 listens for it I would expect it to not be blocked from reaching the other plugins...

[stuckless]

Originally Posted by bialio

I'll check when I get home today to see if P3 is for some reason consuming the RecordingCompleted hook. I would be surprised if it was, and even if P3 listens for it I would expect it to not be blocked from reaching the other plugins...

I really don't think that P3 could consume it, totaly, unless it went into an endless loop. Maybe I'll turn on SageTV event logging and see what that leads me.

[CollegeProject]

Originally Posted by stuckless

I really don't think that P3 could consume it, totaly, unless it went into an endless loop. Maybe I'll turn on SageTV event logging and see what that leads me.

Is this commercial skip plugin a hook in the STV or a implementation class? I can't imagine Phoenix doing anything to the later. I've always down mine via folder monitoring myself.

[tmiranda]

Just noticed this thread. I've been working with stuckless in the CommercialDetector thread on this. My guess is that something is going wrong when the plugin is loaded by the core. Maybe a jar collision? If somebody posts a logfile showing the system startup I'll take a look at it.

[bialio]

FYI - anyone watching the P3 there's a new update in the Plugin Repo. I expect there will be one more towards the end of the weekend also.

btl.

[-=Jeff=-]

Okay dumb question (sorry been a while)
Win 10 machine, I have SageTV v9. I install P3, but how do I activate it? I assume I can see this on the the Main UI on my machine right? still shows a default UI

Nevermind, I think I have it figured out

[tmiranda]

Originally Posted by tmiranda

Just noticed this thread. I've been working with stuckless in the CommercialDetector thread on this. My guess is that something is going wrong when the plugin is loaded by the core. Maybe a jar collision? If somebody posts a logfile showing the system startup I'll take a look at it.

I've been looking at this and have hit a roadblock. Using P3 the CommercialDetector plugin isn't getting the RecordingCompleted or RecordingStopped events. I tried updating the manifest to exclude the SageTV7 dependency and that made no difference at all.

I also tried reverting back to the default UI using the option in the settings and that made no difference.

If I uninstall Phoenix3 and all of the dependencies (there are a lot of them), then the events are sent to CommercialDetector as expected.

The only thing that I see in the logfile when P3 is loaded that is suspicious is this:

Sun 11/13 9:16:27.716 [PluginEventQueue@47073c1c] CD: sageEvent: event received = RecordingScheduleChanged
Sun 11/13 9:16:27.754 [PluginEventQueue@47073c1c] CD: SystemStatus: Number running = 0
Sun 11/13 9:16:27.754 [PluginEventQueue@47073c1c] CD: SystemStatus: No jobs running.
Sun 11/13 9:16:27.755 [PluginEventQueue@47073c1c] CD: SystemStatus: No jobs in queue.
Sun 11/13 9:16:27.755 [PluginEventQueue@47073c1c] CD: sageEvent: Intelligent scheduling is disabled.
Sun 11/13 9:16:27.755 [PluginEventQueue@47073c1c] CD: sageEvent: event received = RecordingScheduleChanged
Sun 11/13 9:16:27.755 [PluginEventQueue@47073c1c] CD: SystemStatus: Number running = 0
Sun 11/13 9:16:27.755 [PluginEventQueue@47073c1c] CD: SystemStatus: No jobs running.
Sun 11/13 9:16:27.755 [PluginEventQueue@47073c1c] CD: SystemStatus: No jobs in queue.
Sun 11/13 9:16:27.755 [PluginEventQueue@47073c1c] CD: sageEvent: Intelligent scheduling is disabled.
Sun 11/13 9:16:27.782 [PSNATMGR@37bdb2c4] Starting UPnP NAT Manager...
Sun 11/13 9:16:27.840 [PluginEventQueue@47073c1c] java.lang.NullPointerException
Sun 11/13 9:16:27.841 [PluginEventQueue@47073c1c] 	at sage.plugin.CorePluginManager.getLatestRepoPlugins(CorePluginManager.java:528)
Sun 11/13 9:16:27.842 [PluginEventQueue@47073c1c] 	at sage.api.PluginAPI$2.runSafely(PluginAPI.java:51)
Sun 11/13 9:16:27.842 [PluginEventQueue@47073c1c] 	at sage.PredefinedJEPFunction.run(PredefinedJEPFunction.java:112)
Sun 11/13 9:16:27.842 [PluginEventQueue@47073c1c] 	at sage.Catbert.evaluateAction(Catbert.java:1663)
Sun 11/13 9:16:27.842 [PluginEventQueue@47073c1c] 	at sage.SageTV.api(SageTV.java:81)
Sun 11/13 9:16:27.842 [PluginEventQueue@47073c1c] 	at sagex.remote.EmbeddedSageAPIProvider.callService(EmbeddedSageAPIProvider.java:16)
Sun 11/13 9:16:27.843 [PluginEventQueue@47073c1c] 	at sagex.SageAPI.call(SageAPI.java:171)
Sun 11/13 9:16:27.843 [PluginEventQueue@47073c1c] 	at sagex.api.PluginAPI.GetAllAvailablePlugins(PluginAPI.java:51)
Sun 11/13 9:16:27.843 [PluginEventQueue@47073c1c] 	at sagex.phoenix.plugin.PhoenixPlugin.onPluginsLoaded(PhoenixPlugin.java:249)
Sun 11/13 9:16:27.843 [PluginEventQueue@47073c1c] 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
Sun 11/13 9:16:27.843 [PluginEventQueue@47073c1c] 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
Sun 11/13 9:16:27.843 [PluginEventQueue@47073c1c] 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
Sun 11/13 9:16:27.843 [PluginEventQueue@47073c1c] 	at java.lang.reflect.Method.invoke(Method.java:498)
Sun 11/13 9:16:27.843 [PluginEventQueue@47073c1c] 	at sagex.plugin.AbstractPlugin.invoke(AbstractPlugin.java:267)
Sun 11/13 9:16:27.843 [PluginEventQueue@47073c1c] 	at sagex.plugin.AbstractPlugin.sageEvent(AbstractPlugin.java:201)
Sun 11/13 9:16:27.843 [PluginEventQueue@47073c1c] 	at sage.plugin.PluginEventManager.run(PluginEventManager.java:241)
Sun 11/13 9:16:27.843 [PluginEventQueue@47073c1c] 	at java.lang.Thread.run(Thread.java:745)

And I can't say I fully understand what's happening here. My uninformed guess is that after the NPE in the CorePluginManager happens the core thinks there is something wrong with the plugin and stops sending events to it?

All I can say for sure is that when P3 and all of the dependencies are removed this NPE does not occur after the RecordingScheduleChanged event is received and CommercialDetector works normally.

This seems to be the offending method:

  public PluginWrapper[] getLatestRepoPlugins()
  {
    return (PluginWrapper[]) latestRepoPlugins.values().toArray(new PluginWrapper[0]);
}

[CollegeProject]

It looks to me there is a NPE being called by sagex by someone. Maybe sage just gives up at that point on that hook so the rest never receive it? My guess would also be something else in Phoenix is implementing that hook and has the NPE

I wonder if there is implementation class that is being return to sage as null that is almost what it appears