P3 beta testing feedback

[stuckless]

Originally Posted by tmiranda

I've been looking at this and have hit a roadblock. Using P3 the CommercialDetector plugin isn't getting the RecordingCompleted or RecordingStopped events. I tried updating the manifest to exclude the SageTV7 dependency and that made no difference at all.

I also tried reverting back to the default UI using the option in the settings and that made no difference.

If I uninstall Phoenix3 and all of the dependencies (there are a lot of them), then the events are sent to CommercialDetector as expected.

The only thing that I see in the logfile when P3 is loaded that is suspicious is this:

Sun 11/13 9:16:27.716 [PluginEventQueue@47073c1c] CD: sageEvent: event received = RecordingScheduleChanged
Sun 11/13 9:16:27.754 [PluginEventQueue@47073c1c] CD: SystemStatus: Number running = 0
Sun 11/13 9:16:27.754 [PluginEventQueue@47073c1c] CD: SystemStatus: No jobs running.
Sun 11/13 9:16:27.755 [PluginEventQueue@47073c1c] CD: SystemStatus: No jobs in queue.
Sun 11/13 9:16:27.755 [PluginEventQueue@47073c1c] CD: sageEvent: Intelligent scheduling is disabled.
Sun 11/13 9:16:27.755 [PluginEventQueue@47073c1c] CD: sageEvent: event received = RecordingScheduleChanged
Sun 11/13 9:16:27.755 [PluginEventQueue@47073c1c] CD: SystemStatus: Number running = 0
Sun 11/13 9:16:27.755 [PluginEventQueue@47073c1c] CD: SystemStatus: No jobs running.
Sun 11/13 9:16:27.755 [PluginEventQueue@47073c1c] CD: SystemStatus: No jobs in queue.
Sun 11/13 9:16:27.755 [PluginEventQueue@47073c1c] CD: sageEvent: Intelligent scheduling is disabled.
Sun 11/13 9:16:27.782 [PSNATMGR@37bdb2c4] Starting UPnP NAT Manager...
Sun 11/13 9:16:27.840 [PluginEventQueue@47073c1c] java.lang.NullPointerException
Sun 11/13 9:16:27.841 [PluginEventQueue@47073c1c] 	at sage.plugin.CorePluginManager.getLatestRepoPlugins(CorePluginManager.java:528)
Sun 11/13 9:16:27.842 [PluginEventQueue@47073c1c] 	at sage.api.PluginAPI$2.runSafely(PluginAPI.java:51)
Sun 11/13 9:16:27.842 [PluginEventQueue@47073c1c] 	at sage.PredefinedJEPFunction.run(PredefinedJEPFunction.java:112)
Sun 11/13 9:16:27.842 [PluginEventQueue@47073c1c] 	at sage.Catbert.evaluateAction(Catbert.java:1663)
Sun 11/13 9:16:27.842 [PluginEventQueue@47073c1c] 	at sage.SageTV.api(SageTV.java:81)
Sun 11/13 9:16:27.842 [PluginEventQueue@47073c1c] 	at sagex.remote.EmbeddedSageAPIProvider.callService(EmbeddedSageAPIProvider.java:16)
Sun 11/13 9:16:27.843 [PluginEventQueue@47073c1c] 	at sagex.SageAPI.call(SageAPI.java:171)
Sun 11/13 9:16:27.843 [PluginEventQueue@47073c1c] 	at sagex.api.PluginAPI.GetAllAvailablePlugins(PluginAPI.java:51)
Sun 11/13 9:16:27.843 [PluginEventQueue@47073c1c] 	at sagex.phoenix.plugin.PhoenixPlugin.onPluginsLoaded(PhoenixPlugin.java:249)
Sun 11/13 9:16:27.843 [PluginEventQueue@47073c1c] 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
Sun 11/13 9:16:27.843 [PluginEventQueue@47073c1c] 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
Sun 11/13 9:16:27.843 [PluginEventQueue@47073c1c] 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
Sun 11/13 9:16:27.843 [PluginEventQueue@47073c1c] 	at java.lang.reflect.Method.invoke(Method.java:498)
Sun 11/13 9:16:27.843 [PluginEventQueue@47073c1c] 	at sagex.plugin.AbstractPlugin.invoke(AbstractPlugin.java:267)
Sun 11/13 9:16:27.843 [PluginEventQueue@47073c1c] 	at sagex.plugin.AbstractPlugin.sageEvent(AbstractPlugin.java:201)
Sun 11/13 9:16:27.843 [PluginEventQueue@47073c1c] 	at sage.plugin.PluginEventManager.run(PluginEventManager.java:241)
Sun 11/13 9:16:27.843 [PluginEventQueue@47073c1c] 	at java.lang.Thread.run(Thread.java:745)

And I can't say I fully understand what's happening here. My uninformed guess is that after the NPE in the CorePluginManager happens the core thinks there is something wrong with the plugin and stops sending events to it?

All I can say for sure is that when P3 and all of the dependencies are removed this NPE does not occur after the RecordingScheduleChanged event is received and CommercialDetector works normally.

This seems to be the offending method:

  public PluginWrapper[] getLatestRepoPlugins()
  {
    return (PluginWrapper[]) latestRepoPlugins.values().toArray(new PluginWrapper[0]);
}

Good job in troubleshooting this. I can confirm that I have the same exception during startup as well. I actually didn't htink much of it, since I've always had a couple sagetv exceptions during startup, and I read this exception closely.

This seems like the bug that jusjoken found where when handling the AllPluginsLoaded event, when you try to access the Plugin Manager you get a NPE. This should be fixed in SageTV core, but, I can also work around it for this 1 case in Phoenix as well.

I'll do a phoenix update today, and then look at what would be required to have sagetv "wait" before crashing when the plugin manager is requested.

I was about to post, that I don't think this is comskip issue, since I've also noticed that I'm NOT getting metadata/fanart on new items when they are added to SageTV, so all these things are likley related to this. Good find.

[tmiranda]

Originally Posted by CollegeProject

It looks to me there is a NPE being called by sagex by someone. Maybe sage just gives up at that point on that hook so the rest never receive it? My guess would also be something else in Phoenix is implementing that hook and has the NPE

I wonder if there is implementation class that is being return to sage as null that is almost what it appears

The NPE is being created by whatever plugin is getting the RecordingScheduleChanged event after CommercialDetector. When I look at the code the line after the "Intelligent scheduling is disabled" message is "return".

This line looks like a good place to start:
at sagex.phoenix.plugin.PhoenixPlugin.onPluginsLoaded(PhoenixPlugin.java:249)

[tmiranda]

Originally Posted by stuckless

Good job in troubleshooting this. I can confirm that I have the same exception during startup as well. I actually didn't htink much of it, since I've always had a couple sagetv exceptions during startup, and I read this exception closely.

This seems like the bug that jusjoken found where when handling the AllPluginsLoaded event, when you try to access the Plugin Manager you get a NPE. This should be fixed in SageTV core, but, I can also work around it for this 1 case in Phoenix as well.

I'll do a phoenix update today, and then look at what would be required to have sagetv "wait" before crashing when the plugin manager is requested.

I was about to post, that I don't think this is comskip issue, since I've also noticed that I'm NOT getting metadata/fanart on new items when they are added to SageTV, so all these things are likley related to this. Good find.

Glad I could help

[stuckless]

Originally Posted by tmiranda

Glad I could help

It's interesting, because, Phoenix already uses a try/catch (throwable) to eat any exceptions during that event, so this is happening in the core sagetv that must be causing it to have issues. I'll do so troubleshooting based on that exception and see what I find. thx.

[HokiePerogi]

I'm feeling really silly right now, but I can't seem to find P3 in the plugins repository on my v9 install. Do I need to do something special to get it to show up? I made sure that beta versions are shown via the repository options screen.

I'm running 9.0.9.441 on Win7.

[bialio]

It's under the Full UI tab of the plugin manager (make sure you go in via 'Available plugins')

[HokiePerogi]

Originally Posted by bialio

It's under the Full UI tab of the plugin manager (make sure you go in via 'Available plugins')

I'm missing something....somewhere. See attached screenshot.

[jusjoken]

Originally Posted by HokiePerogi

I'm missing something....somewhere. See attached screenshot.

Do you have java 8 as that is a requirement

[HokiePerogi]

Originally Posted by jusjoken

Do you have java 8 as that is a requirement

No. I guess that would be it.

Before I go and install Java 8, is there anything else I need to be concerned about? I thought I read somewhere on the forums that not everything in the SageTV universe is Java 8 compatible.


Thanks.

[jusjoken]

Originally Posted by HokiePerogi

No. I guess that would be it.

Before I go and install Java 8, is there anything else I need to be concerned about? I thought I read somewhere on the forums that not everything in the SageTV universe is Java 8 compatible.


Thanks.

Some users report some issues with the web apps....but not everyone.

[HokiePerogi]

Originally Posted by jusjoken

Do you have java 8 as that is a requirement

Well...I installed Java 8. SageTV reports java version of 1.8.0_111.

However, I'm still not seeing P3 in the plugin's repository. I haven't restarted the entire PC yet. I'll try that next, just in case.

[panteragstk]

Things are getting weird. Now sage is completing media scans in seconds and isn't finding anything new.

I've removed P3 (didn't want to) and it didn't help. I don't think all of the dependencies got removed.

Am I missing something?

[bialio]

I haven't seen anything like that. Did you Update anything else recently?

[panteragstk]

Originally Posted by bialio

I haven't seen anything like that. Did you Update anything else recently?

Other than Sean's phoenix update and your minor update to P3 no. It worked just fine before that.

I don't see how they could be related, but I figured I'd post here just in case.

[jusjoken]

Originally Posted by panteragstk

Other than Sean's phoenix update and your minor update to P3 no. It worked just fine before that.

At a glance at the logs the plugins are not all loading correctly especially the dev manifest...perhaps check that..

The are also a lot of errors around mounts and files but not sure what those mean.

k

[panteragstk]

Originally Posted by jusjoken

At a glance at the logs the plugins are not all loading correctly especially the dev manifest...perhaps check that..

The are also a lot of errors around mounts and files but not sure what those mean.

k

Thanks. I'll remove the dev and see if that helps. I haven't installed the plugin, but I'll make sure.

I also have a SagetvPluginsv9.xml. Is that supposed to be there along with the regular SageTVPlugins.xml? The regular one hasn't been modified since Oct and the v9 was modified a few days ago.

[tmiranda]

Originally Posted by panteragstk

Thanks. I'll remove the dev and see if that helps. I haven't installed the plugin, but I'll make sure.

I also have a SagetvPluginsv9.xml. Is that supposed to be there along with the regular SageTVPlugins.xml? The regular one hasn't been modified since Oct and the v9 was modified a few days ago.

That's normal.

[panteragstk]

Originally Posted by tmiranda

That's normal.

Figured as much.

Removed the dev.xml and no change.

Any other ideas? I really don't want to have to re-do my install, but maybe removing ALL plugins will help? Seems kinda strange that plugins that haven't been updated in a long time would suddenly cause this issue.

[bialio]

I guess a log from after removing the SageTVPluginsDev.xml file would be good.

What is the main issue you are seeing?

[HokiePerogi]

Originally Posted by HokiePerogi

Well...I installed Java 8. SageTV reports java version of 1.8.0_111.

However, I'm still not seeing P3 in the plugin's repository. I haven't restarted the entire PC yet. I'll try that next, just in case.

Still no luck. I can't seem to get P3 to show up in the available plugins list. Logs attached.