Plugin: CommercialDetector

[phelme]

Originally Posted by tmiranda
...
- Change color of comskip icon next to show that is being processed.
...

Here you mentioned that the color of the CS icon should be different for the recording currently being processed. I'm seeing this on some, but not all of my clients (Placeshifters for one don't, maybe they are not supported?). I have v1.2 installed everywhere.

Any ideas what I should be looking for to debug this? Thanks.

[psicat]

Originally Posted by tmiranda

Yes, the CS icon should show up in the header (SageCleints as well as extenders) when something is being processed. If it's not something is wrong or nothing is being processed.

I checked that comskip is indeed running (task manager), plus my new recordings are getting flagged properly. I tried killing comskip and it launched another process. I had 5 or so recordings queued manually by deleted their .edl files and pressing the Queue button in the config screen. So, it appears to be working in the background properly.

Originally Posted by tmiranda

Are .edl files getting generated for new recordings or not? If not, set debugging to Trace and post a log for me to look at.

Yep, it's working. But still no CS icon in the display header.

No big deal. I can live without it, but it's a nice detail.

[tmiranda]

Originally Posted by sacrament055

Since you're asking for suggestions and you mentioned no comskip if type feature you could add support for no comskip if - channel = premium movie network.. (HBO, Showtime etc that don't have commercials)

That's already available. Look in the options and there is a place to enter channels to not run comskip on. You can put in the name (HBO, Show, ..) ot the channel number.

[Fuzzy]

Originally Posted by psicat

I checked that comskip is indeed running (task manager), plus my new recordings are getting flagged properly. I tried killing comskip and it launched another process. I had 5 or so recordings queued manually by deleted their .edl files and pressing the Queue button in the config screen. So, it appears to be working in the background properly.


Yep, it's working. But still no CS icon in the display header.

No big deal. I can live without it, but it's a nice detail.

Are you sure you have the UI Mod plugin installed as well "Commercial Detector UI"? This is the mod that adds the CS icon.

[tmiranda]

Originally Posted by ChePazzo

My question to the group: Is there any place I can change the cmd that is run to not include the -s option?

What shell are you using?

[tmiranda]

@psicat and phelme - I'll have to look into the icon issue some more. It sounds like you are both having similar issues.

[psicat]

Originally Posted by Fuzzy

Are you sure you have the UI Mod plugin installed as well "Commercial Detector UI"? This is the mod that adds the CS icon.

Yes, the UI mod is also installed. I might try uninstalling and re-installing everything and see if that makes a difference.

[HelenWeathers]

I too am having the same issue with the CS icon. Seems to show up for a while on the extender I installed from, then next day is not there (although I do see files being created). I have tried uninstalling and re-installing - behavior is the same.

I would like to voice my desire to be able to define the hours comskip can be triggered, OR define the hours comskip should not be triggered.

I love the ease of installation/setup of the commercial detector plugin.

I donated to get the comskip version that supports .ts files and, although not 100% yet, it works very well so far.

In setup I had to add txt and logo.txt files to list of files to be deleted with log and edl files. Extensions appear to be case sensative BTW.

[ChePazzo]

Originally Posted by tmiranda

What shell are you using?

bash

it's not just wine, either. It's anything (see code output below).

mike@sagebuntu:~$ echo $SHELL
/bin/bash

mike@sagebuntu:~$ sudo echo $SHELL
[sudo] password for mike: 
/bin/bash

mike@sagebuntu:~$ sudo -H -u mike echo $SHELL
/bin/bash

mike@sagebuntu:~$ sudo -H -u mike -s echo $SHELL
/bin/echo: /bin/echo: cannot execute binary file

[toricred]

Originally Posted by tmiranda

If I let SA handle the queue I can't easily monitor the progress or determine how many jobs are running. I'm not an expert on SA, is there a reason why I should use their queue management?

The reason to use SA instead of the engine is so that you can monitor the progress of each engine through the SA GUI. When you call the engine directly you lose that functionality. In addition you would not have to monitor how many are running simultaneously because SA will take care of that for you. Finally, there are features to limit disk bandwidth usage per engine and I don't believe this works if you call the engine directly.

Not a huge deal, just different than what I'm used to.

[tmiranda]

I'll look into the CS icon issue and the linux issue as soon as reasonably possible. After that I'll look into restricting comskipping to certain times.

Thanks for your feedback.

Tom

[MrE]

Thanks for the great plugin. I had always meant to get around to installing and configuring ComSkip and this really made it easy.

Now I just have to break the habit of reaching for the remote to skip commercials.

[tmiranda]

@ChePazzo - Are you running the Sage process as root or as a user? If a user, which one? If as root, which user has wine installed?

Can you double check that you have the configuration options set correctly for linux?

Tom

[phelme]

Originally Posted by tmiranda

@psicat and phelme - I'll have to look into the icon issue some more. It sounds like you are both having similar issues.

The CS icon is showing in the header for me on all clients, but the differentiating icon on the individual recording currently being comskipped is inconsistent. Thanks for looking into it.

[ChePazzo]

Originally Posted by tmiranda

@ChePazzo - Are you running the Sage process as root or as a user? If a user, which one? If as root, which user has wine installed?

Can you double check that you have the configuration options set correctly for linux?

Tom

Sage is running as root
user: mike has wine installed

What configuration options do I need to check?
if you mean the plugin configuration through the sage ui, then I set the "sage running as root" to "true" and the "wine running as user" to "mike"

[tmiranda]

That's the info I was looking for and it is setup correctly. Can you try one more thing for me please? Get to a shell as root and then try the command line to see what happens. I suspect you will get the same results but I want to make sure.

Tom

[ChePazzo]

Originally Posted by tmiranda

That's the info I was looking for and it is setup correctly. Can you try one more thing for me please? Get to a shell as root and then try the command line to see what happens. I suspect you will get the same results but I want to make sure.

Tom

like this:

root@sagebuntu:~# sudo -H -u mike echo $SHELL
/bin/bash

root@sagebuntu:~# sudo -H -u mike -s echo $SHELL
/bin/echo: /bin/echo: cannot execute binary file

root@sagebuntu:~# echo $SHELL
/bin/bash

root@sagebuntu:~# whoami
root

root@sagebuntu:~# sudo -H -u mike whoami
mike

root@sagebuntu:~# sudo -H -u mike -s whoami
/usr/bin/whoami: /usr/bin/whoami: cannot execute binary file

[tmiranda]

Yes. I figured that would also fail.

Can you show me the log a few lines before the command is run? I'm specifically interested in the line that begins: "run: WinePath ".

Using sudo with the -s allows me to pass the shell specific environment variables that need to be set. On my machine the only vars I set are WINEPREFIX and WINEPATH, maybe in your setup we need to set more. I'm thinking there is something different about your environment / environment variables that I have not taken into account.

Sorry for all of the prodding, but this works fine on my system and I need your assistance to help debug. I'm not an expert at linux either Maybe the best course of action is simply to run the commadn without the -s but I want to be sire of that.

Tom

[ChePazzo]

Originally Posted by tmiranda

Yes. I figured that would also fail.

Can you show me the log a few lines before the command is run? I'm specifically interested in the line that begins: "run: WinePath ".

grabbed 10 before and 10 after. let me know if you needed more than that or if you need me to change the debug level.

Tue 9/14 12:14:52.510 [Thread-2823@432be4] CD: QueuedJob: Looking for comskip ini.
Tue 9/14 12:14:52.510 [Thread-2823@432be4] CD: QueuedJob: Looking for comskip ini file /opt/sagetv/server/CommercialDetector/comskip/TheDailyShowWithJonStewart.ini
Tue 9/14 12:14:52.510 [Thread-2823@432be4] CD: QueuedJob: Looking for comskip ini file /opt/sagetv/server/CommercialDetector/comskip/COMEDY.ini
Tue 9/14 12:14:52.510 [Thread-2823@432be4] CD: QueuedJob: No ini found, using default.
Tue 9/14 12:14:52.510 [Thread-2823@432be4] CD: plugin: STVPath = /opt/sagetv/server/STVs/SageTV7
Tue 9/14 12:14:52.510 [Thread-2823@432be4] CD: run: WinePath /home/mike/.wine/
Tue 9/14 12:14:52.511 [Thread-2823@432be4] CD: run: Job parts 1
Tue 9/14 12:14:52.511 [Thread-2823@432be4] CD: run: Processing /var/media3/tv/TheDailyShowWithJonStewart-111797-0.mpg
Tue 9/14 12:14:52.511 [Thread-2823@432be4] CD: hasAnEdlOrTxtFile: Looking for existing file /var/media3/tv/TheDailyShowWithJonStewart-111797-0.edl
Tue 9/14 12:14:52.511 [Thread-2823@432be4] CD: hasAnEdlOrTxtFile: Looking for existing file /var/media3/tv/TheDailyShowWithJonStewart-111797-0.txt
Tue 9/14 12:14:52.511 [Thread-2823@432be4] CD: run: Command sudo -H -u mike -s wine /opt/sagetv/server/comskip/comskip.exe --ini=/opt/sagetv/server/comskip/comskip.ini /var/media3/tv/TheDailyShowWithJonStewart-111797-0.mpg
Tue 9/14 12:14:52.577 [Thread-2824@bbd1] CD: stderr: /usr/bin/wine: /usr/bin/wine: cannot execute binary file
Tue 9/14 12:14:52.579 [Thread-2823@432be4] CD: run: comskip return code = 126
Tue 9/14 12:14:52.579 [Thread-2823@432be4] CD: run: comskip failed with return code = 126
Tue 9/14 12:14:52.579 [Thread-2823@432be4] CD: ComskipManager: job has completed with status true
Tue 9/14 12:14:52.579 [Thread-2823@432be4] CD: readQueuedJobs: complete. null
Tue 9/14 12:14:52.580 [Thread-2823@432be4] CD: readQueuedJobs: found 0
Tue 9/14 12:14:52.580 [Thread-2823@432be4] CD: ComskipManager: No more jobs to process.
Tue 9/14 12:14:52.580 [Thread-2823@432be4] CD: CSC removeStatus: item before remove 356352348,,344,340,336,332,328,324,320,316,312,308,304,300,296,292,288,284,280,276,272,268,264,260,256,252,248,244,240,236,232,228,224,220,216,212,208,204,200,196,192,188,184,180,176,172,168,164,160,156,152,148,144,140,136,132,124,120,108,104,100,92,84,80,76,68,60,56,52,44,39,584,580,576,572,568,564,560,556,552,548,544,540,536,532,528,524,520,516,512,508,504,500,496,492,488,484,480,476,472,468,464,460,456,452,448,444,440,436,432,428,424,420,416,412,408,404,400,396,392,388,384,380,376,372,368,360,356,352,348,344,340,336,332,328,324,320,316,312,308,304,296,292,288,280,276,268,264,260,252,248,240,236,232,228,224,220,212,208,204,200,196,192,188,180,172,168,160,156,152,148,144,140,136,132,120,108,104,100,92,84,80,76,68,60,52,44,39,357017,357017,39,172,316,340,360,384,408,428,444,460,476,480,504,512,528,540,552,568,192303,192419,192431,192435,192451,192463,192471,192479,192487,192495,192511,192519,192523,192531,192543,192551,192563,192579,192587,192595,192607,192615,192627,192635,192651,192663,192671,192687,192699,192707,192715,192803,192815,192835,192843,192855,192859,192867,192875,192887,192895,192899,192935,362721,357426,357383,357365,357362,357069,357027,357026,357025,357020,357017,357016,333695,333693,333683,192891,192883,192879,192871,192863,192851,192847,192839,192831,192827,192823,192819,192811,192807,192799,192795,192791,192787,192783,192779,192775,192771,192767,192763,192759,192755,192751,192747,192743,192739,192735,192731,192727,192723,192719,192711,192703,192695,192691,192683,192679,192675,192667,192659,192655,192647,192643,192639,192631,192623,192619,192611,192603,192599,192591,192583,192575,192571,192567,192559,192555,192547,192539,192535,192527,192515,192507,192503,192499,192491,192483,192475,192467,192459,192455,192447,192443,192439,192427,192423,192415,192411,192407,192403,192399,192395,192391,192387,192383,192379,192375,192371,192367,192363,192359,192355,192351,192347,192335,192331,192327,192323,192311,192307,192299,192295,192291,192287,192283,192271,192267,192263,192259,192255,192251,192247,612,608,604,600,596,592,588,584,580,576,572,564,560,556,548,544,536,532,524,520,516,508,500,496,492,488,484,472,468,464,456,452,448,440,436,432,424,420,416,412,404,400,396,392,388,380,376,372,368,356,352,348,344,336,332,328,324,320,312,308,304,300,296,292,288,284,280,276,272,268,264,260,256,252,248,244,240,236,232,228,224,220,216,212,208,204,200,196,192,188,184,180,176,168,164,160,156,152,148,144,140,136,132,124,120,108,104,100,92,84,80,76,68,60,56,52,44,357383,357383,357383
Tue 9/14 12:14:52.581 [Thread-2823@432be4] Exception in thread "Thread-2823" Tue 9/14 12:14:52.581 [Thread-2823@432be4] java.lang.NumberFormatException: For input string: ""
Tue 9/14 12:14:52.581 [Thread-2823@432be4] 	at java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)

Originally Posted by tmiranda

Sorry for all of the prodding, but this works fine on my system and I need your assistance to help debug.

No problem at all. I'm happy to help in any way. I've used the comskip with the autoskip for a while now, but never had integration like this, so this is great. Even with this one issue, the full-package integration is excellent.

I'm pretty excited about the new GUI for installing plugins and such and it really shows SageTVs commitment to maintaining an open platform while still making money!

[tmiranda]

That log helped a lot. It also shows me why the CS Icon is not always showing.