Plugin: CommercialDetector

[mechling-burgh]

I know your busy but I have an idea or request. Could you add a run only manual option. Commercial detector seems to work best for me on my daughters reality TV shows so I only like to run it on them. I thought if you could add run only manual option or maybe run on these favorites option. That way you can only have it run on a few shows instead of every show. I have used the channel option which helps a bit. Thank you

[tmiranda]

Originally Posted by mechling-burgh

I know your busy but I have an idea or request. Could you add a run only manual option. Commercial detector seems to work best for me on my daughters reality TV shows so I only like to run it on them. I thought if you could add run only manual option or maybe run on these favorites option. That way you can only have it run on a few shows instead of every show. I have used the channel option which helps a bit. Thank you

I already added an option on my development version to run only on Favorites. It shouldn't be hard to expand that to be Manuals as well.

[cculpepp]

I'm new to SageTV and commercial detector and have been using it for the past week. I must say though, I'm not overly impressed with Comskip because it misses commercials about 50% of the time. If I upgrade Comskip to the donor version, will I see better performance out of it? Is it worth it?

[Greg2dot0]

Originally Posted by cculpepp

I'm new to SageTV and commercial detector and have been using it for the past week. I must say though, I'm not overly impressed with Comskip because it misses commercials about 50% of the time. If I upgrade Comskip to the donor version, will I see better performance out of it? Is it worth it?

I've had good results with the donators version. On average I'd say fairly accurate. I'm only using 1 configuration. You can set up Comskip by channel to have different settings if you're into the time it takes to do it.

[jptheripper]

im on the dontators version. On a high quality signal (cable, cablecard, OTA) i would say its 95%+ accurate

[Taddeusz]

Originally Posted by cculpepp

I'm new to SageTV and commercial detector and have been using it for the past week. I must say though, I'm not overly impressed with Comskip because it misses commercials about 50% of the time. If I upgrade Comskip to the donor version, will I see better performance out of it? Is it worth it?

What are your tuners? You may need to follow the directions to tweak detection.

[cculpepp]

Originally Posted by Taddeusz

What are your tuners? You may need to follow the directions to tweak detection.

I'm using the HDHomerun Connect (OTA).

[Taddeusz]

Originally Posted by cculpepp

I'm using the HDHomerun Connect (OTA).

Shouldn't require any special tweaks but maybe logo detection isn't working right. As a general policy I restrict logo detection to the bottom of the screen since usually weather warnings appear at the top and can throw things off.

[Taddeusz]

Not sure the exact reason for the error but I set extended_filenames to true in my properties and now comskip exits with an error code 2. I can't see the command line it's using but as I'm running on unRAID I assume that for Linux it's not putting "\ " for spaces in the filename.

[stuckless]

Originally Posted by Taddeusz

Not sure the exact reason for the error but I set extended_filenames to true in my properties and now comskip exits with an error code 2. I can't see the command line it's using but as I'm running on unRAID I assume that for Linux it's not putting "\ " for spaces in the filename.

I'm not sure how the comskip is launched, but, "\ " is not needed, if the filename is passed a complete arg to the process. (Tom, can you confirm how "comskip" is called.

[Taddeusz]

Any idea on this yet? I actually had comskip successfully run on Agents of S.H.I.E.L.D. last night but it didn't work on any of the other recordings. Not sure what made that one special.

In the meantime I've been running it manually from the command-line.

[tmiranda]

Originally Posted by Taddeusz

Any idea on this yet? I actually had comskip successfully run on Agents of S.H.I.E.L.D. last night but it didn't work on any of the other recordings. Not sure what made that one special.

In the meantime I've been running it manually from the command-line.

Attach a logfile for me to look at.

[Taddeusz]

Originally Posted by tmiranda

Attach a logfile for me to look at.

Ok, I just changed the logging level to Maximum. I'll have something later.

[Taddeusz]

Originally Posted by tmiranda

Attach a logfile for me to look at.

Ok, here is a log file. Looks like the pertinent data starts at line 5830. It looks like it is a problem with the spaces. Probably needs "\" before the spaces.

[Taddeusz]

Oh, and there wasn't a recording that worked last night. We were at a friend's house and they were watching Agents of S.H.I.E.L.D. so I kind of assumed they were watching it live. It was obviously a recording.

[EnterNoEscape]

Starting Saturday, I had an old problem come back. This is especially a problem for network encoders when using Comskip on active recordings. Basically what happens is the file is created, but it's not written just yet. Comskip opens the zero length file, errors out and never comes back. The recording finishes and later in the week, I discover that I need to manually trigger Comskip which does work through the plugin and eventually all of the commercials are marked.

Back when I used SJQ more extensively, knowing about this problem, I added a delay when a recording started before it would actually kick off Comskip. The way it was written, one of 2 conditions had to be true. Either the recording was completed or 5 minutes since the start of the recording had passed. This not only fixed the problem, but it was also kind of nice when I was going from channel to channel not to have Comskip kicking off immediately on every change. Any chance we can have a configurable delay when running commercial detection live?

[tmiranda]

Originally Posted by Taddeusz

Is there a way for this plugin to use the natively compiled comskip rather than running through Wine? Maybe there's a solution that I haven't seen?

I think I know what's happening. In the meantime, attached is the jar that will allow you to run comskip natively under linux. I do not have the native comskip build, you can get that from stuckless.

To use this:
- Stop your server.
- Get the native comskip, rename it to comskip64 or comskip32 (depending on your linux architecture) and place it in the comskip directory.
- Unzip the jar file and overwrite the existing jar (in the JARs directory).
- Restart Sage and go to the Plugin options, you will see an option to run comskip natively.

Let me know if you need help and if it fixes your problem.

Tom

[Taddeusz]

Originally Posted by tmiranda

I think I know what's happening. In the meantime, attached is the jar that will allow you to run comskip natively under linux. I do not have the native comskip build, you can get that from stuckless.

To use this:
- Stop your server.
- Get the native comskip, rename it to comskip64 or comskip32 (depending on your linux architecture) and place it in the comskip directory.
- Unzip the jar file and overwrite the existing jar (in the JARs directory).
- Restart Sage and go to the Plugin options, you will see an option to run comskip natively.

Let me know if you need help and if it fixes your problem.

Tom

This appears to be working. I'll let you know if I run into any problems.

[Taddeusz]

Just to let you know comskip ran successfully on all of last night's recordings. Thank you!

[tmiranda]

Originally Posted by Taddeusz

Just to let you know comskip ran successfully on all of last night's recordings. Thank you!

Great. I should probably clean up the code and make a new release.