Plugin: CommercialDetector

[ldavis]

Originally Posted by tmiranda

I had not thought about changing the behavior of the "Run Comskip" button, but if it's something people want I can probably make it happen in a future release.

Let me just say that the option to override time and channel restrictions would be great. As mentioned in this thread there can be problems recording and watching too many HD shows at once while trying to run comskip. For me the problems have been such that I simply blackout comskip during prime time. It would be great to be able to comskip that once in a while show that we actually watch the night it airs!!!

[tmiranda]

Originally Posted by HelenWeathers

The -0 edl, txt etc files were deleted when the recording was deleted but the -1 files were not.

I just looked at the code and this is indeed a bug that will be addressed it in the next release.

Thanks for spotting this Helen.

I'll be away on a business trip for a few days and will have no time to do much about this until next week.

[Sambo555]

Originally Posted by tmiranda

I see a few people downloaded the "Forum Beta", any feedback? I do know it broke the "restricted times" functionality, but I've already fixed that.

toricred? Sambo555? Tomahawk51?

I just tried it today on a couple of shows I was watching live. Sage moved them to the partially deleted section as expected. The shows were still being comskipped.

Good news, once I deleted video files from there than comm detector removed all the associated comskip files.

I'm still seeing the orphan issue though. I left orphan files behind to see what would happen and they're still sitting there. I went into the plugin and chose 'delete all orphaned....' and it showed the number of orphaned files but did not delete them. I tried it again and same thing. Is the orphan deletion set to run on a schedule or when user selects this?

Log shows deletions not occurring. I've attached the logs with portions concerning the orphan files and deletion. Hope it helps.

[Suntan]

I've always been interested in adding commercial skipping, just never got around to it. However, this implementation was so easy it was a no brainer to plug it in. Thanks, it is appreciated.

One question I do have, is it possible to configure it so that the show plays without automatically skipping the commercials and then when you press the "skip forward" button inside a blue commercial break section it will automatically jump to the end of that group of commercials?

Currently, setting it to automatically skip commercials works, but I don't see very high WAF for it that way. If I turn that selection off, then all I get is "notification" where the commercials are (in the form of the blue highlights in the timebar) but I don't have any way to "jump" to the end of the commercials, it just jumps in the regular 30 sec intervals.

-Suntan

[HelenWeathers]

Originally Posted by Suntan

Currently, setting it to automatically skip commercials works, but I don't see very high WAF for it that way. If I turn that selection off, then all I get is "notification" where the commercials are (in the form of the blue highlights in the timebar) but I don't have any way to "jump" to the end of the commercials, it just jumps in the regular 30 sec intervals.

-Suntan

After turning off autoskip, you can press the right navigation button to skip to the end of the commercial break during playback.

[Fuzzy]

Originally Posted by HelenWeathers

After turning off autoskip, you can press the right navigation button to skip to the end of the commercial break during playback.

conversely, the left arrow will skip backwards through marker's.

[toricred]

I've tried the new version and I thought it wasn't working last night, but I discovered that there was a problem with the recording I thought had a problem.

Long story short, my issue is fixed. Next question is about the "Run Comskip" button. I'm using TVE and I'm not seeing that button. What dialog should I see it on?

[HelenWeathers]

Originally Posted by toricred

Long story short, my issue is fixed. Next question is about the "Run Comskip" button. I'm using TVE and I'm not seeing that button. What dialog should I see it on?

When you select a recording that's been processed by CS you should see the Delete Comskip Files choice in your options dialog. Shows that have not been processed yet by CS should instead show the Run Comskip choice in the same window.

[Suntan]

Originally Posted by HelenWeathers

After turning off autoskip, you can press the right navigation button to skip to the end of the commercial break during playback.

Yeah, after posting I actually tried that while lying in bed and then felt a little silly for not trying it sooner.

Anyway, I think that will be acceptable to the War Department to have skip forward 30 sec and skip to end of commercial breaks on two different buttons. After playing with it, personally I think it is better to have them separate as they are now.

Thanks again for the great plugin tmiranda.

-Suntan

[bbbrad]

Hi,

Total Sage Noobie...Anyway, I installed the CommercialDetector plugin and comskip appears to be running properly (it generates comskip files, displays the cs icon, queues up and analyzes show etc.) but the comskip info is not showing up on the timeline when I watch the show and I can't skip over the commercials. My timeline is basically solid green with no marking for where the commercials are.
I've played around with the settings under customizations but no success. Am I missing something? Was there something else I needed to do besides simply install the plugin? Can anyone give me a few pointers?
Thanks!

[Fuzzy]

the CommercialDetector plugin only does what you are describing: launches comskip to analyse the shows. It does not actually read the .edl files. That is handled by a different UI Mod plugin entirely: 'Comskip Playback' by JREkiwi, razrsharpe. The general plugin 'CommercialDetector' does not automatically install 'Comskip Playback', though I believe the UI Mod 'CommercialDetector UI' does.

[toricred]

Originally Posted by HelenWeathers

When you select a recording that's been processed by CS you should see the Delete Comskip Files choice in your options dialog. Shows that have not been processed yet by CS should instead show the Run Comskip choice in the same window.

I was afraid of this. With TVE it must not be using the same dialog as that option isn't there. I may look into doing this through studio since I won't let go of TVE, but I really would like to have this option as well.

[tmiranda]

Originally Posted by Sambo555

I just tried it today on a couple of shows I was watching live. Sage moved them to the partially deleted section as expected. The shows were still being comskipped.

Good news, once I deleted video files from there than comm detector removed all the associated comskip files.

This is normal. The shows will be processed but if Sage auto-deletes the partials, or you manually delete them, everything should get deleted and cleaned up properly.

I'm still seeing the orphan issue though. I left orphan files behind to see what would happen and they're still sitting there. I went into the plugin and chose 'delete all orphaned....' and it showed the number of orphaned files but did not delete them. I tried it again and same thing. Is the orphan deletion set to run on a schedule or when user selects this?

Log shows deletions not occurring. I've attached the logs with portions concerning the orphan files and deletion. Hope it helps.

The "Delete All Orphaned" function is purely a manual process. If you don't select it, it will never be run.

Thanks for the log, I see the deletions failed, but I do not know why. It's on my "to do" list.

[tmiranda]

Originally Posted by toricred

I was afraid of this. With TVE it must not be using the same dialog as that option isn't there. I may look into doing this through studio since I won't let go of TVE, but I really would like to have this option as well.

I'll look into this as well. I'm going from memory but I think when I ported TVE I used the existing dialog.

I'm just back from a business trip so it may take a few days to get to this.

[tmiranda]

Originally Posted by HelenWeathers

I had an ATSC station transmission error for about 3 minutes a few nights ago which resulted in a programname-#####-0.mpg and a programname-#####-1.mpg (two mpg files).

The -0 edl, txt etc files were deleted when the recording was deleted but the -1 files were not.

I discovered them the next day while browsing and deleted them so not sure if they would have been deleted eventually if I had left them.

Helen,

I believe this is being caused by a bug in Sage. I've filed a bug report and will let you know when I hear back. The workaround is easy but I'm going to hold off on adding it until I hear back from Sage support.

[tmiranda]

Originally Posted by tmiranda

Thanks for the log, I see the deletions failed, but I do not know why. It's on my "to do" list.

I think the attached .jar file corrects the issue Sambo555 was having with not deleting the orphans. To install:
- stop Sage
- make a backup copy of CommercialDetector.jar
- unzip the attached CommercialDetector.jar file in the JARs directory
- restart Sage

[uberpixel]

I've made a bunch of changes lately so I'm not sure how this started but...

With comskip running on 2 threads at a time and processing active recordings, the cpu load goes to 100% and SageTV v7 becomes unusable. I've tried disabling comskip and every calms back down. I also hear heavy hard drive activity when comskip is running.

Comskip was running fine in the configuration noted above except for one or two hiccups per hour in my recordings so I decided I needed to make it better.

I rebuilt my WHS system around a 1.8ghz Intel E4300 Core2Duo (which should have been an upgrade from the single core 3.0ghz P4 530).

After the upgrade I also installed the most recent v7 beta software from SageTV.

I got an error message that I had run out of memory so I adjusted my Java heap size to 512mb.

I've also been get "Halt detected" errors and occasional "no signal" errors.

Not sure if comskip is the problem or just a symptom... Any ideas what's going on or how I can troubleshoot?

[toricred]

I tried using the built-in recordings menu and I still don't see anything about run comskip or deleting the edl files. I'm not actually using comskip, but rather ShowAnalyzer. Could that be a clue that I have some setting missing?

[Sambo555]

Originally Posted by tmiranda

I think the attached .jar file corrects the issue Sambo555 was having with not deleting the orphans.

That .jar fixed deleting orphan files.

Awesome work! Thank you.

[Fuzzy]

Originally Posted by toricred

I tried using the built-in recordings menu and I still don't see anything about run comskip or deleting the edl files. I'm not actually using comskip, but rather ShowAnalyzer. Could that be a clue that I have some setting missing?

First check would be, do you have the 'Commercial Detector UI' plugin installed? (It is in the UI Mod section).