Plugin: CommercialDetector

[BobPhoenix]

Originally Posted by adone36

Isn't there a spec in the plugin config where you specify file types???

Yes there is and the defaults don't include MKV and AVI as far as I can remember. So it would have to have been changed to pick up those. Unless you are auto converting the recordings in SageTV as that could be happening first before Commercial Detector picks them up.

[nyplayer]

Originally Posted by BobPhoenix

Yes there is and the defaults don't include MKV and AVI as far as I can remember. So it would have to have been changed to pick up those. Unless you are auto converting the recordings in SageTV as that could be happening first before Commercial Detector picks them up.

I just reinstalled it yesterday and it was setup that way I did not change any defaults. I know enough not to try and comskip avis etc.... and I am not auto converting any recordings.

This is how it was setup. It could be something that was leftover from a previous Installation as Commercial Detector does not appear to cleanup its properties settings.

cd/video_ext=mpg,mp4,avi,ts,mkv

[adone36]

While we are discussing file types, etc, I noticed Sage will support playing back wtv files but timeline does not show properly (skip ahead does not work, etc).

I have the donator version of Comskip (which supports wtv) and added wtv to the files in the comskip plug in. I run comskip on the wtv files and the directories contain the edl files, but Sage shows the different colors on the timeline bar, but it does not skip. So I think there may be something going on with the way the plugin works.

[nyplayer]

I did a fresh Install on my test machine that never had Commercial detector installed. It has all the files as valid. See screenshot attached. If you scan for files not comskipped it will add all the TV files regardless of extension.

[sflamm]

Based on tmiranda's comment:

Several times you may want to run comskip manually:
- If you import recordings.
- If you edit the comskip.ini to try to get better results.

it makes sense that scanning for all files not comskipped would include not just the sagetv recording types, but also video that you might import from elsewhere that has commercials.

[sflamm]

Comskip now has multi-thread support:

Add
thread_count=2
to your config.ini for the fastest multiple comskip decoding.
When only running one instance of comskip on a multicore CPU you can set
thread_count=4
for even faster processing.

http://www.kaashoek.com/comskip/view...php?f=1&t=1130

[sflamm]

Is it possible to apply the

videoframe/disable_timescaling_on_seek=true

to the properties files of the SageTV extenders?
Or is this unnecessary since it is in the SageTV server properties file?

[sflamm]

Does the 'Scan All Recordings' parameter apply only to the 'RecordedTV' directories?

[Fuzzy]

Originally Posted by sflamm

Is it possible to apply the

videoframe/disable_timescaling_on_seek=true

to the properties files of the SageTV extenders?
Or is this unnecessary since it is in the SageTV server properties file?

There is a configuration option as part of the comskip playback stvi to do this (not a part of CommercialDetector, but installed with it):

Setup -> Detailed Setup -> Customize -> Comskip Playback Options -> Operation Options -> Disable Timeline Scaling == Yes

Just make this change from each extender, and it will set it in that extender's properties file. (You could, also, just make the change in the properties file on the server. each extender has it's own properties file in the SageTV/Clients folder on the server, named for the extender's MAC address. But the UI change is much easier.

[sflamm]

Right - I looked in the extender client config files first and didnt notice the parameter at all...

I wanted to confirm that adding it manually actually has an effect on the extenders.

I run SageMC on my extenders so I do not have the Comskip Playback Plugin configured for the extenders (SageMC and Phoenix have the feature built-in...) so it should be unnecessary.

By adding the entry manually I should get a more accurate commercial timeline for the extenders correct? (using either comskip or SAV)

[Fuzzy]

yes, it should. It is not in the .properties file by default, but adding it (with the service shut down) will enable the feature (technically, disable the scaling feature)

[tmiranda]

Originally Posted by sflamm

Does the 'Scan All Recordings' parameter apply only to the 'RecordedTV' directories?

No, it will look for every MediaFile that is video. I think the questions was answered but there is a setting in there to tell CommercialDetector what type of files to process.

[sflamm]

Got it. Would be nice if you ever get a chance to have an option just to look in the RecordedTV directories....

Typically anything else would not have commercials...

[nyplayer]

How do you prevent commercials from being detected on MKV files .... When I transcode to MKV and delete the original files it will run Comskip on the mkv even though the edl exists.... and exactly where is that setting to tell it only to run on mpg? The only option I see is cleanup of files.

[adone36]

Remove mkv from the file types in the plugin config.

[nyplayer]

Originally Posted by adone36

Remove mkv from the file types in the plugin config.

The problem with that is wouldn't it delete EDL files when it does it cleanup for the mpg files?


I will do some testing see what happens.

[adone36]

It is going to "clean up" when you delete the video file. Why are you comskipping and then converting? Why not convert and then comskip?

Are you talking imports or recordings?

[nyplayer]

Originally Posted by adone36

It is going to "clean up" when you delete the video file. Why are you comskipping and then converting? Why not convert and then comskip?

Are you talking imports or recordings?

I do live Comskipping and autoconvert some Favorites. I am testing now it appears to be working with just the mpg. After conversion even though the MPG is deleted it is not deleting the EDL so your suggestion appears to work.

PS I was not converting then Comskipping because I did not use the Donator version and that would not do MKV...

[Taddeusz]

Why would the commercial detector be violating the set restricted times? I have the restricted times set from 07:00 till 23:59. It is currently running detection on two recordings. I've checked Process Explorer and it says that they were started at 08:04 and 08:40. It does have 7 recordings in the queue but shouldn't it wait to start those until the restriction is lifted at midnight?

[tmiranda]

Originally Posted by Taddeusz

Why would the commercial detector be violating the set restricted times? I have the restricted times set from 07:00 till 23:59. It is currently running detection on two recordings. I've checked Process Explorer and it says that they were started at 08:04 and 08:40. It does have 7 recordings in the queue but shouldn't it wait to start those until the restriction is lifted at midnight?

Sounds like a bug. Can you turn on debug logging in Sage, set the debug level in the plugin to "trace", reproduce the problem and then upload the logfile? I will take a look to see what's going on.