Plugin: CommercialDetector

[KarylFStein]

Originally Posted by tmiranda

I was going to ask stuckless. He packages everything up and puts it in the docker.

I apologize but I have very little time to spare at the moment. Lots of clients trying to get their "year end reviews" done

No worries. I'll just turn off spaces in file names for now.

Maybe I'm confused how this works. In the docker there is a native comskip in /opt/sagetv/comskip. (There is no comskip.exe in there or comskip64.) When I install the plugin it creates /opt/sagetv/server/comskip where it has the comskip.exe Windows binary, but no comskip64. So I thought you were expecting the comskip64 to go in there.

I can point my comskip binary to point to the one in the docker, but the UI has no option for "use native comskip". So it seems to me like I'm somehow pulling an older version. Or was the one with the "use native" option just posted on here as a JAR and never made it to the plugin?

[tmiranda]

Originally Posted by KarylFStein

No worries. I'll just turn off spaces in file names for now.

Maybe I'm confused how this works. In the docker there is a native comskip in /opt/sagetv/comskip. (There is no comskip.exe in there or comskip64.) When I install the plugin it creates /opt/sagetv/server/comskip where it has the comskip.exe Windows binary, but no comskip64. So I thought you were expecting the comskip64 to go in there.

I can point my comskip binary to point to the one in the docker, but the UI has no option for "use native comskip". So it seems to me like I'm somehow pulling an older version. Or was the one with the "use native" option just posted on here as a JAR and never made it to the plugin?

I've never used the docker and can't really tell you the details but I know the "use native comskip" option should be in there, it's not new. If you select that option then the plugin looks for comskip64 in the same directory as you have told it to look for comskip. It then runs comskip64 as a native linux executable.

It should work with spaces in the file name and/or file name, I've tested that.

[uberpixel]

Is it possible to set a specific .ini file for a certain program name AND channel?

I'd like to create a "CollegeFootball" AND "ESPNHD" profile that ignores the bottom 10% of the screen during logo detection since the ticker tends to stay put during the commercials and it appears that logo detection fails as a result.

I've had success with an "ESPNHD" profile when recording College Football, but the problem is that not all ESPNHD content uses the ticker during commercials - it only appears to be the case for select programs.

-uberpixel

[tmiranda]

Originally Posted by uberpixel

Is it possible to set a specific .ini file for a certain program name AND channel?

I'd like to create a "CollegeFootball" AND "ESPNHD" profile that ignores the bottom 10% of the screen during logo detection since the ticker tends to stay put during the commercials and it appears that logo detection fails as a result.

I've had success with an "ESPNHD" profile when recording College Football, but the problem is that not all ESPNHD content uses the ticker during commercials - it only appears to be the case for select programs.

-uberpixel

Not currently. I will add it to the To Do list.

[tmiranda]

Originally Posted by KarylFStein

I'm more interested in why it seems like I'm not getting the correct plugin bits, (no "native comskip" option or comskip64 binary). Any thought on where to look to track that down?

I took a look at the code and still don't understand why you are seeing this odd behavior. What version of the jar are you running? When the server starts, look for the line "CD: PlugIn: Starting. Version = ". It should be 1.14.

[KarylFStein]

Originally Posted by tmiranda

I took a look at the code and still don't understand why you are seeing this odd behavior. What version of the jar are you running? When the server starts, look for the line "CD: PlugIn: Starting. Version = ". It should be 1.14.

Well, that seems to be a problem:

Tue 11/28 19:45:20.755 [ReProcessHook@da6be87] CD: PlugIn: Starting. Version = 1.00

I did an uninstall and reinstall of all the comskip things recently, so that is up-to-date according to my system. Nothing in the plugins area shows as having an update available. I haven't manually done anything to my SageTVPlugins.xml files.

[tmiranda]

Originally Posted by KarylFStein

Well, that seems to be a problem:

Tue 11/28 19:45:20.755 [ReProcessHook@da6be87] CD: PlugIn: Starting. Version = 1.00

I did an uninstall and reinstall of all the comskip things recently, so that is up-to-date according to my system. Nothing in the plugins area shows as having an update available. I haven't manually done anything to my SageTVPlugins.xml files.

EDIT: That explains a lot. I see there is an issue with the manifest. I will correct this soon.

In the mean time you can use the attached jar.

[tmiranda]

I just released version 1.16 of the plugin. It corrects the manifest issue that caused an older version on the plugin to be loaded.

[tmiranda]

Originally Posted by uberpixel

Is it possible to set a specific .ini file for a certain program name AND channel?

I'd like to create a "CollegeFootball" AND "ESPNHD" profile that ignores the bottom 10% of the screen during logo detection since the ticker tends to stay put during the commercials and it appears that logo detection fails as a result.

I've had success with an "ESPNHD" profile when recording College Football, but the problem is that not all ESPNHD content uses the ticker during commercials - it only appears to be the case for select programs.

-uberpixel

Try the attached jar. It will look for an .ini file in the same directory as comskip with ShowName-ChannelName.ini. In your example it will look for CollegeFootball-ESPNHD.ini

Let me know how it goes.

[KarylFStein]

Originally Posted by tmiranda

I just released version 1.16 of the plugin. It corrects the manifest issue that caused an older version on the plugin to be loaded.

Cool, it's working now, thanks.

[uberpixel]

Originally Posted by tmiranda

Try the attached jar. It will look for an .ini file in the same directory as comskip with ShowName-ChannelName.ini. In your example it will look for CollegeFootball-ESPNHD.ini

Let me know how it goes.

Great! I'll give a try. I might have to find another scenario now that college football has basically come to an end, but I'm guessing basketball has the same set up.

-uberpixel

[tmiranda]

Originally Posted by uberpixel

Great! I'll give a try. I might have to find another scenario now that college football has basically come to an end, but I'm guessing basketball has the same set up.

-uberpixel

Did this work for you?

[uberpixel]

Originally Posted by tmiranda

Did this work for you?

I tried it out today on a bowl game on ESPN. Couldn’t tell if it worked or not. My Comskip algorithm definitely didn’t work well but I can’t tell which one it picked. Is there a way to tell in a log file or something which config file it is actually using?

-uberpixel

[tmiranda]

Originally Posted by uberpixel

I tried it out today on a bowl game on ESPN. Couldn’t tell if it worked or not. My Comskip algorithm definitely didn’t work well but I can’t tell which one it picked. Is there a way to tell in a log file or something which config file it is actually using?

-uberpixel

The logfile will show which was used.

[uberpixel]

Originally Posted by tmiranda

The logfile will show which was used.

Where is the logfile located?

-uberpixel

[tmiranda]

Originally Posted by uberpixel

Where is the logfile located?

-uberpixel

On the server in the same directory as the SageTV executable. It's the standard logfile.

[uberpixel]

Originally Posted by tmiranda

On the server in the same directory as the SageTV executable. It's the standard logfile.

Sorry. Not really sure what I’m looking for in the log file. I don’t see any refer necessary to a Comskip config file.

[tmiranda]

Originally Posted by uberpixel

Sorry. Not really sure what I’m looking for in the log file. I don’t see any refer necessary to a Comskip config file.

The file is called sagetv_0.txt and is located in the same directory as the sage executable. Look for lines starting with "CD:" One of them will show the command line used to execute comskip. That will show what .ini file is being used.

[TwistedMelon]

Is it possible to exclude particular favorites from having Comskip run on them?

[tmiranda]

Originally Posted by TwistedMelon

Is it possible to exclude particular favorites from having Comskip run on them?

No. I think there is a hidden setting that will exclude all Favorites but not specific favorites.