Embedded subtitles?

[stanger89]

Are they showing up as available for selection but not showing? Or is it as if they aren't there at all?

[Toddupton]

They are all there and I can select any of them but none of them work. Something had to have been changed between 7 and 9. Captions on tv works for recordings as well as .srt files it just will not read the subtitles in the .mkv package.

[Taddeusz]

Originally Posted by Toddupton

They are all there and I can select any of them but none of them work. Something had to have been changed between 7 and 9. Captions on tv works for recordings as well as .srt files it just will not read the subtitles in the .mkv package.

What type of subtitles are they? Can you post a MediaInfo dump of one or two?

[Toddupton]

Here are 2 samples

[stanger89]

Originally Posted by Toddupton

They are all there and I can select any of them but none of them work. Something had to have been changed between 7 and 9. Captions on tv works for recordings as well as .srt files it just will not read the subtitles in the .mkv package.

Weird, I haven't had any issues with MKV subs since upgrading to V9.

[Toddupton]

I know this is nuts. I can instal 7 and it works I do a fresh install of 9 and won't work neither will an upgrade from 7 to 9.

[Toddupton]

Anyone have anymore ideas?

[trk2]

I would post this in the Open Source forum since this seems to be a V9 issue instead of a media extender issue. You're more likely to attract the attention you need if you post in that forum.

[Toddupton]

I just installed the 9.1 version going up from old sageTV 7 and everything is great except embedded subtitles no longer work on my HD300. Is this a known issue or just me? Thx

* merged & moved to open source forum; see previous posts for details *

[Taddeusz]

I'm going to test an mkv with VOB subtitles. Most of the movies in my collection that have subtitles are ripped from Blu-ray. When I rip from DVD I convert to AVC and burn the subtitles into the video. I discovered that the MPEG2 video from DVD's varies so much that converting it is more compatible. Burning the subtitles gets around the limitation of SageTV not recognizing the mkv forced flag.

I'll post back with my findings.

[Taddeusz]

Ok, I've verified on my HD300 that VOBSUB subtitles don't show. It doesn't look like anything in the log is obviously wrong. Maybe someone else can figure it out. The video I played was "Wolf Creek (2005).mkv" and I changed subs a few times.

[Taddeusz]

Just to add I tested one of my Blu-ray rips with PGS subtitles and they aren't working now either. Something has definitely changed. This was working on a previous v9 release.

[wnjj]

Originally Posted by Taddeusz

Ok, I've verified on my HD300 that VOBSUB subtitles don't show. It doesn't look like anything in the log is obviously wrong. Maybe someone else can figure it out. The video I played was "Wolf Creek (2005).mkv" and I changed subs a few times.

Is this a clue or normal? I'm not sure if DVDSubtitle is what we're dealing with here.

Sat 7/8 18:42:20.995 [FinalRender-0023a5000d5b@1695e046] MiniClient did not succeed with menu hint change to:menuName:MediaPlayer OSD, popupName:DVDSubtitle, hasTextInput:false, errcode=1

EDIT: Looks like menu hints were added to support the Android mini player and may simply be unsupported by the HD300. In other words I think this error may be normal.

[wnjj]

What about this stuff?

Sat 7/8 18:42:29.635 [VideoFrame-0023a5000d5b@12ad1e2c] VIDEO FRAME EXCEPTION THROWN:java.lang.IllegalMonitorStateException
Sat 7/8 18:42:29.635 [VideoFrame-0023a5000d5b@12ad1e2c] java.lang.IllegalMonitorStateException
Sat 7/8 18:42:29.635 [VideoFrame-0023a5000d5b@12ad1e2c] java.util.concurrent.locks.ReentrantReadWriteLock$Sync.tryRelease(ReentrantReadWriteLock.java:371)
Sat 7/8 18:42:29.636 [VideoFrame-0023a5000d5b@12ad1e2c] java.util.concurrent.locks.AbstractQueuedSynchronizer.release(AbstractQueuedSynchronizer.java:1261)
Sat 7/8 18:42:29.636 [VideoFrame-0023a5000d5b@12ad1e2c] java.util.concurrent.locks.ReentrantReadWriteLock$WriteLock.unlock(ReentrantReadWriteLock.java:1131)
Sat 7/8 18:42:29.636 [VideoFrame-0023a5000d5b@12ad1e2c] sage.media.sub.VobSubSubtitleHandler.getSubtitleBitmap(VobSubSubtitleHandler.java:441)

Some file handling for CC was overhauled/changed about a year ago but not sure if it's relevant to this issue.

Notice this error starts from an attempt to release a lock on a file in VobSibtitleHandler.

Pull request from last year here: https://github.com/google/sagetv/pull/156

[stuckless]

Originally Posted by wnjj

What about this stuff?

Sat 7/8 18:42:29.635 [VideoFrame-0023a5000d5b@12ad1e2c] VIDEO FRAME EXCEPTION THROWN:java.lang.IllegalMonitorStateException
Sat 7/8 18:42:29.635 [VideoFrame-0023a5000d5b@12ad1e2c] java.lang.IllegalMonitorStateException
Sat 7/8 18:42:29.635 [VideoFrame-0023a5000d5b@12ad1e2c] java.util.concurrent.locks.ReentrantReadWriteLock$Sync.tryRelease(ReentrantReadWriteLock.java:371)
Sat 7/8 18:42:29.636 [VideoFrame-0023a5000d5b@12ad1e2c] java.util.concurrent.locks.AbstractQueuedSynchronizer.release(AbstractQueuedSynchronizer.java:1261)
Sat 7/8 18:42:29.636 [VideoFrame-0023a5000d5b@12ad1e2c] java.util.concurrent.locks.ReentrantReadWriteLock$WriteLock.unlock(ReentrantReadWriteLock.java:1131)
Sat 7/8 18:42:29.636 [VideoFrame-0023a5000d5b@12ad1e2c] sage.media.sub.VobSubSubtitleHandler.getSubtitleBitmap(VobSubSubtitleHandler.java:441)

Some file handling for CC was overhauled/changed about a year ago but not sure if it's relevant to this issue.

Notice this error starts from an attempt to release a lock on a file in VobSibtitleHandler.

Pull request from last year here: https://github.com/google/sagetv/pull/156

That's a good catch, and it is likely that the issue is a sideeffect of this change. The code changed from using syncronized blocks to using read/write locks, which can perform better than syncronized, but comes at a cost of complexity and more possibility for errors.

I'm not sure why the code changed from using synchronized blocks to this, and in reviewing the changed, I don't see anything that stands out as being wrong (and after reading the comments, I don't see jeff questioning this as well).

The only thing that I would likely change is to use NonFair locking which will perform than synchronized and offer same protections, where as Fair locking performs worse, generally.

There is a good article, for those that are interested, on using Reentrant Lock in Java vs Synchronized.

https://www.ibm.com/developerworks/j...ry/j-jtp10264/

Typically using a ReadWrite lock would be used in cases where extreme performance is critical or when lists are extremely large. I don't see this code as fitting either of those cases. Personally, I would not have rewritten it use ReadWrite locks, and at a glance it appears to be implemented correctly, but the error is proof that somewhere, unlock() is being called more times than lock().

[stuckless]

Actually after re-reviewing it again, I found 2 errors in the locking...

https://github.com/google/sagetv/blo...dler.java#L282

and

https://github.com/google/sagetv/blo...ndler.java#L61

In both of these cases, it will result in an error in the unlock(), because lock() is never called.

I'll enter an issue for this.

[Malfunction]

Originally Posted by Toddupton

I just installed the 9.1 version going up from old sageTV 7 and everything is great except embedded subtitles no longer work. Is this a known issue or just me? Thx

My subtitles also don't work. SageTV detects them, but they don't appear on my screen. The checkbox appears in the menu when I play a MKV file with subtitles. MPC and VLC play them without issues.

[Taddeusz]

Originally Posted by Malfunction

My subtitles also don't work. SageTV detects them, but they don't appear on my screen. The checkbox appears in the menu when I play a MKV file with subtitles. MPC and VLC play them without issues.

Make sure you are updated to the latest version of SageTV. There was a fix already implemented for this problem.

[Malfunction]

Originally Posted by Taddeusz

Make sure you are updated to the latest version of SageTV. There was a fix already implemented for this problem.

Done, still broken. There must be a different issue.

[Narflex]

It's going to depend upon what client you are using for playing them back..what are you using for playback?