BMT Issue downloading images for TVDB

[jvl711]

Hi,

I noticed over the last few days the BMT was having issues downloading images for new shows. After a few hours of banging my head I decided to look into the code to try and debug the issue. It looks like TVDB is forcing HTTPS connections, and BMT is trying to pull images using HTTP connections. The java HttpURLConnection does not support following redirects from HTTP to HTTPS. I am not sure if there is an easier way to fix that issue, but I made the following code change after googling the issue for a while.

Hopefully I will save someone the same agrevation I just went through looking into this issue. Of course I assumed I broke something!


sagex.phoenix.util.url.UrlUtil

public static URLConnection openUrlConnection(URL url, String userAgent, String referrer, int timeout, boolean followRedirects)
            throws IOException, SocketTimeoutException 
    {
        UrlConfiguration cfg = GroupProxy.get(UrlConfiguration.class);
        URLConnection conn = url.openConnection();
        
        if (conn instanceof HttpURLConnection) 
        {
            
            if (userAgent == null) 
            {
                userAgent = cfg.getHttpUserAgent();
            }
            if (userAgent != null) 
            {
                conn.setRequestProperty("User-Agent", userAgent);
            }
            if (referrer != null) 
            {
                conn.setRequestProperty("REFERER", referrer);
            }
            
            //((HttpURLConnection) conn).setInstanceFollowRedirects(followRedirects);
            
            if(((HttpURLConnection)conn).getResponseCode() == HttpURLConnection.HTTP_MOVED_TEMP || ((HttpURLConnection)conn).getResponseCode() == HttpURLConnection.HTTP_MOVED_PERM )
            {
                
                URL resourceUrl, base, next;
                String location;
  
                location = conn.getHeaderField("Location");
                
                location = URLDecoder.decode(location, "UTF-8");
                
                
                base = new URL(url.toExternalForm());
                next = new URL(base, location); 
                
                
                return openUrlConnection(next,userAgent, referrer, timeout, followRedirects);
                
            }
        }

        if (timeout <= 0) 
        {
            timeout = cfg.getReadTimeoutMS();
        }

        if (timeout > 0) 
        {
            conn.setReadTimeout(timeout);
            conn.setConnectTimeout(timeout);
        }

        return conn;
        
    }

[stuckless]

That is the fix. It was also talked here, as well.

Now I just need to find the time to update Phoenix (you could send a pull request)

[jvl711]

Originally Posted by stuckless

That is the fix. It was also talked here, as well.

Now I just need to find the time to update Phoenix (you could send a pull request)

I submitted a pull request. I think I did it correctly. I used the website editor to make the changes.

Thanks,
Josh

[stuckless]

Originally Posted by jvl711

I submitted a pull request. I think I did it correctly. I used the website editor to make the changes.

Thanks,
Josh

Awesome... I will push out a new phoenix before the end of the weekend... promise

[jusjoken]

Originally Posted by stuckless

Awesome... I will push out a new phoenix before the end of the weekend... promise

EXCELLENT NEWS!!!!

[nateziemann]

Originally Posted by stuckless

Awesome... I will push out a new phoenix before the end of the weekend... promise

new update worked for me. Had to upgrade from sage 9.1.5 to newer version due to new gemstone prereq. but all worked well. Thank you !!

[jusjoken]

Originally Posted by stuckless

Awesome... I will push out a new phoenix before the end of the weekend... promise

New version resolved for me.

Thanks all.

[Polypro]

Another perfect fix, thanks team! This reminds me of the "old days" - you guys are as good, if not better () than the OEM Sage crew!!!